Adar Dembo has posted comments on this change.

Change subject: [tests] de-flaking catalog_manager_tsk-itest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8017/1//COMMIT_MSG
Commit Message:

> OK, here the result running without and with 21b0f3d5 changelist:
I can buy that the new approach to failure detection could require rejiggering 
of test parameters in order to find the new boundaries.

However, if the logs/timings show that election convergence is net _less 
efficient_ than it was before that change, then it'd be better to treat that as 
a bug and figure out how to fix that than it'd be to rejigger the boundary 
conditions in this one test.

The main question is whether election convergence is "worse" or just 
"different". If the latter, then I agree with you that we should just tweak the 
timings in this test. But if the former, then we should address that directly.


-- 
To view, visit http://gerrit.cloudera.org:8080/8017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50cee27a579cffa7232137c7039b02a1ad4ab7eb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to