Mike Percy has posted comments on this change. Change subject: Add tablet state summary metrics ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7980/8/src/kudu/tserver/ts_tablet_manager_metrics.h File src/kudu/tserver/ts_tablet_manager_metrics.h: PS8, Line 56: TSTabletManager* ts_tablet_manager; : : FunctionGaugeDetacher metric_detacher; Don't shoot me, but shouldn't these two members be private? Aren't they never meant to be accessed by other classes? -- To view, visit http://gerrit.cloudera.org:8080/7980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fda2061d341586f0aa343787af59984a627080a Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
