David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done
......................................................................


Patch Set 2:

actually nm.
my concern was that we might use done() (which is false by default) without 
has_done() but I realize that the behavior is the same if the field is absent 
from the pb

-- 
To view, visit http://gerrit.cloudera.org:8080/8045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5395bd73edd9cf9d18c4cb6db4f8fb39e5a41830
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to