Andrew Wong has posted comments on this change.

Change subject: docs: clarify steps for changing master from multi-master 
deployment
......................................................................


Patch Set 3:

(5 comments)

See the rendering here:
https://github.com/andrwng/kudu/blob/006ca06da2a91f178ba21a31fa19d01e710c9fd8/docs/administration.adoc

http://gerrit.cloudera.org:8080/#/c/8032/2/docs/administration.adoc
File docs/administration.adoc:

Line 379: master.
> Nit: other WARNING text begins with a capital letter. Below too.
Done


PS2, Line 382: this workflow without also restarting the live masters. As such, 
the workflow requires a
             : maintenance window, albeit a 
> You are technically correct (the best kind of correct) but there are nuance
I added a warning to ensure the leader will be kept (at the otherwise risk of 
sever data loss).


PS2, Line 382: this workflow without also restarting the live masters. As such, 
the workflow requires a
             : maintenance window, albeit a 
> Please double check this with Mike.
Done


PS2, Line 392: 
> nit: master nodes?
Removing this line since I agree with Adar.


PS2, Line 392: 
> I don't really understand why this instruction is worth including. Yes, it 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/8032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4196dbb2f8a185e868a6906c7cf917d79c404c0d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to