Adar Dembo has posted comments on this change. Change subject: KUDU-1807 (part 2): ban GetTableSchema for table createdness in clients ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8026/3/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java: Line 361: * considered to be successful. > That's why I don't like this. We don't want to document this because it's " Let me try to walk this fine line... http://gerrit.cloudera.org:8080/#/c/8026/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: Line 191: * Whether to wait for all tablets to be created before the table creation is > I think we can't have our cake and eat it too, if we want to expose a publi OK, I'll try to doc the choice between waiting and not waiting more clearly, without getting into implementation details. PS3, Line 199: setWait > Will the new sub-operations also require new setters? We're basically alrea Sorry for not being clear. What I meant is that this wait(), by virtue of being vague, would include waiting on new sub-operations too. It'd be an all-encompassing wait(), which I think is desirable (I don't think waiting for some operations but not others is particularly useful). -- To view, visit http://gerrit.cloudera.org:8080/8026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54fa07dc34a97f1c9da06ec9129d6d4590b7aac6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
