Dan Burkert has posted comments on this change. Change subject: kudu-spark: change default master address to local fqdn ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8072/2/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala File java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala: PS2, Line 38: InetAddress.getLocalHost.getCanonicalHostName > InetAddress.getLocalHost can throw. What happens if we throw in this contex We could change the method to be def defaultMasterAddrs: String = Try(InetAddress.getLocalHost.getCanonicalHostName).getOrElse("localhost"); But that has its own issues. Not really sure how to take this. How common is it for the local hostname not to be resolvable? -- To view, visit http://gerrit.cloudera.org:8080/8072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ec7414c451f54b95d86663d743162688e304ba Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
