Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8128 )
Change subject: Prioritize freeing memory over releasing WAL segments ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8128/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/8128/1/src/kudu/util/maintenance_manager.cc@391 PS1, Line 391: // Look at free memory. If it is dangerously low, we must select something So the goal is to prioritize flushes of large memstores over flushes that retain the most WAL bytes? How does this change accomplish that? Seems like you've just swapped the priority of "flush largest memstore" and "GC some WAL segments". LogGC is super cheap; it's just unlinking some files on disk (hence the "low_io" prefix). -- To view, visit http://gerrit.cloudera.org:8080/8128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0aace7c526878b139420242939462afa76d1b8df Gerrit-Change-Number: 8128 Gerrit-PatchSet: 1 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 21:11:02 +0000 Gerrit-HasComments: Yes
