Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 )
Change subject: KUDU-1125: issue one catalog write per tablet report ...................................................................... Patch Set 6: Code-Review+1 (2 comments) I think Mike should do a pass. http://gerrit.cloudera.org:8080/#/c/8090/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8090/5/src/kudu/master/catalog_manager.cc@3227 PS5, Line 3227: just been added to the committed config and are in the process of bootstrapping. : const ConsensusStatePB& prev_cstate = tablet->metadata().s > I copied this part of the comment verbatim since I don't pretend to underst No, it was a real question. I'm not sure the two are equivalent. http://gerrit.cloudera.org:8080/#/c/8090/5/src/kudu/master/catalog_manager.cc@3408 PS5, Line 3408: tables_lock.Unlock(); > While "table before tablets when acquiring and the reverse when releasing" sounds good -- To view, visit http://gerrit.cloudera.org:8080/8090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f5cf0e4b1cd1160b3b310d89c6dbf3dd62e43b Gerrit-Change-Number: 8090 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sat, 23 Sep 2017 00:43:46 +0000 Gerrit-HasComments: Yes
