Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8124 )
Change subject: [consensus] don't crash in RaftConsensus::ChangeConfig ...................................................................... [consensus] don't crash in RaftConsensus::ChangeConfig Don't crash if ReplicateConfigChangeUnlocked() returns an error. Instead, just return corresponding error to the caller. This is to avoid crashing a tablet server if an invalid Raft configuration is passed to ChangeConfig() RPC with ChangeConfigRequestPB parameter. Also, use move semantics for all parameters of the RaftConsensus::ReplicateConfigChangeUnlocked() method. Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8 Reviewed-on: http://gerrit.cloudera.org:8080/8124 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h 2 files changed, 11 insertions(+), 13 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8 Gerrit-Change-Number: 8124 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]>
