Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 )
Change subject: master-test: fix another source of test flakiness ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc@111 PS1, Line 111: 90 > Is this necessary only for ASAN/TSAN builds or for DEBUG/RELEASE builds as The failure on the dashboard was for RELEASE. To be honest, I think we spend way too much time dwelling on "lowest possible" test timeout values, and then bumping them when flakes show up. I think we're better off using absurdly high timeout values and letting the 900s test timeout kick in when there's an actual bug. -- To view, visit http://gerrit.cloudera.org:8080/8160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9 Gerrit-Change-Number: 8160 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Comment-Date: Thu, 28 Sep 2017 00:33:34 +0000 Gerrit-HasComments: Yes
