Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 )
Change subject: mini-cluster: new module for the mini cluster implementations ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/integration-tests/linked_list-test.cc File src/kudu/integration-tests/linked_list-test.cc: http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/integration-tests/linked_list-test.cc@78 PS1, Line 78: using client::KuduClient; This is both used and forward declared. Was like that originally, but probably a good time to fix. http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/integration-tests/ts_itest-base.h File src/kudu/integration-tests/ts_itest-base.h: http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/integration-tests/ts_itest-base.h@88 PS1, Line 88: cluster::ExternalMiniClusterOptions opts; Consider 'using' it like the other files. http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/mini-cluster/CMakeLists.txt File src/kudu/mini-cluster/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8173/1/src/kudu/mini-cluster/CMakeLists.txt@28 PS1, Line 28: gmock This is a really big list of dependent libraries, considering that this module will eventually be pulled into the production 'kudu' tool. At a minimum it seems like gmock could be removed. -- To view, visit http://gerrit.cloudera.org:8080/8173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0437e281da5874016d9c1f1404a6de043bfb4088 Gerrit-Change-Number: 8173 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 17:39:30 +0000 Gerrit-HasComments: Yes
