Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7853 )
Change subject: tool: add cluster shell action ...................................................................... Patch Set 8: (11 comments) Just skimmed through. Will take a deeper look tomorrow. http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/kudu-tool-test.cc@1843 PS8, Line 1843: ASSERT_FALSE(s.ok()); : ASSERT_TRUE(s.IsInvalidArgument()); here and below: why is it necessary to verify for ASSERT_FALSE(s.ok()); if next line is about ASSERT_TRUE(s.IsInvlidArgument())? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@60 PS8, Line 60: The generated ID of the cluster, unique to the control shell. maybe just: 'ID of the cluster to destroy.' ? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@91 PS8, Line 91: required HostPortPB process_address How does it work for multiple addresses (corresponding to '--rpc_bind_addresses' flag)? Or we never want to have that test cluster bound to multiple addresses? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool.proto@104 PS8, Line 104: HostPortPB Same question if multiple addresses are allowed: which address should be specified here -- the first one or any of the bound addresses? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@20 PS8, Line 20: <stdlib.h> nit: please use <cstdlib> instead. http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@64 PS8, Line 64: ; nit: remove extra semicolon http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@102 PS8, Line 102: InvalidArgument nit: maybe, NotFound is the better choice here? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@133 PS8, Line 133: InvalidArgument ditto regarding NotFound http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@150 PS8, Line 150: FLAGS_serialization == "json" As I see, case-insensitive comparison (i.e. boost::iequals(v, "json")) is used in the validator. Maybe, it makes sense to compare case-insensitive comparison here as well? http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@153 PS8, Line 153: "pb", FLAGS_serialization ditto for case-insensitive comparison. http://gerrit.cloudera.org:8080/#/c/7853/8/src/kudu/tools/tool_action_test.cc@216 PS8, Line 216: opts.master_rpc_ports = { 11030, 11031, 11032 }; nit: add DCHECK_EQ(3, opts.num_masters) ? -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-Change-Number: 7853 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 03 Oct 2017 04:30:17 +0000 Gerrit-HasComments: Yes
