Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8197 )
Change subject: [tablet copy] comment on TabletCopyClient lifecycle ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8197/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/8197/1/src/kudu/tserver/ts_tablet_manager.cc@631 PS1, Line 631: anchor > LogAnchor Done http://gerrit.cloudera.org:8080/#/c/8197/1/src/kudu/tserver/ts_tablet_manager.cc@632 PS1, Line 632: sends RPC notifying the other side, so to the : // source replica destroys corresponding TabletCopySourceSession object, : // which holds the necessary resources, protecting the anchored WAL segments : // from being garbage collected. > ... sends an RPC explicitly ending the tablet session. The source replica t Thank you for cleaning this up. I also did a minor update on the NOTE section below. -- To view, visit http://gerrit.cloudera.org:8080/8197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ae41f12fe75f05c84518c26b6875f34efae0172 Gerrit-Change-Number: 8197 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 04 Oct 2017 17:57:10 +0000 Gerrit-HasComments: Yes
