Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8209
to review the following change.
Change subject: mini-cluster: make available when building with NO_TESTS
......................................................................
mini-cluster: make available when building with NO_TESTS
There's an upcoming patch to the Kudu CLI to add a "control shell" which can
create miniclusters. To that end, the mini-cluster cmake module has to be
available even when building with NO_TESTS=1. Here's what I had to change:
- We need the MiniKdc, so I pulled it out of security-test and into a new
mini_kdc cmake module. While I was there I also renamed security-test to
security_test_util.
- We need kudu_curl_util for ExternalMiniCluster::GetInt64Metric, so I
pulled it out of its NO_TESTS=1 guard.
- We need some kudu_test_util functions for MiniKdc and MiniCluster binary
paths and data roots, so I also pulled it out of its NO_TESTS=1 guard.
Change-Id: I7b2fae0144b602bdfefbc44a7f98205f0d8a4a30
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
M src/kudu/rpc/CMakeLists.txt
M src/kudu/security/CMakeLists.txt
M src/kudu/server/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
6 files changed, 53 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8209/1
--
To view, visit http://gerrit.cloudera.org:8080/8209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b2fae0144b602bdfefbc44a7f98205f0d8a4a30
Gerrit-Change-Number: 8209
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>