Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8247 )
Change subject: Allow configuration of values passed into kebreros env vars ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8247/1/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/8247/1/src/kudu/security/init.cc@467 PS1, Line 467: if (krb5_ktname.empty()) { : setenv("KRB5_KTNAME", FLAGS_keytab_file.c_str(), 1); : } else { : setenv("KRB5_KTNAME", krb5_ktname.c_str(), 1); : } This is a little ugly, but making the FLAGS_keytab_file available in the init.h file for the sake of a default arg value, causes quite a few gflags problems. -- To view, visit http://gerrit.cloudera.org:8080/8247 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab4ce72c04ec4056dc89fb4c1c540a6fdaca4404 Gerrit-Change-Number: 8247 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 10 Oct 2017 06:26:59 +0000 Gerrit-HasComments: Yes
