David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 )
Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8245/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8245/1//COMMIT_MSG@10 PS1, Line 10: remaining nodes what are the "remaining nodes"? do you mean a viable majority or all of the other nodes? http://gerrit.cloudera.org:8080/#/c/8245/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/8245/1/src/kudu/consensus/consensus_queue.cc@383 PS1, Line 383: auto unreachable_time = now - peer->last_successful_communication_time; > It might actually be better here to use peer->is_last_exchange_successful o guess we should be clearer as to what "viable" is, agreed that slow but responding is still viable. we've defined timeouts to make that distinction. -- To view, visit http://gerrit.cloudera.org:8080/8245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I673f5b8a58b3954ea28066ecb334b3fdd60e7adb Gerrit-Change-Number: 8245 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 10 Oct 2017 18:50:15 +0000 Gerrit-HasComments: Yes
