Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8250 )
Change subject: java-client: enforce that only Java 7 APIs are used ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8250/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8250/2//COMMIT_MSG@10 PS2, Line 10: both maven and gradle plugins. The maven plugin doesn't check test code [1], > Do we need to check test code? Wouldn't it be okay to write test code that I think we should definitely check test code, since both production and test code are built by 'mvn package', thus the presence of Java 8 API calls in test code will break JDK7 builds. FWIW, the original issue that spurred all of this was a Java 8 call in MiniKuduCluster (see commit c929a06), which is test code. http://gerrit.cloudera.org:8080/#/c/8250/2/java/gradle/quality.gradle File java/gradle/quality.gradle: http://gerrit.cloudera.org:8080/#/c/8250/2/java/gradle/quality.gradle@74 PS2, Line 74: signature 'org.codehaus.mojo.signature:java17:1.0@signature' > Is their some ay we could leverage the "javaCompatibility" value in gradle. Sure, we could convert '1.7' into 'java17' and append a version of 1.0, but that seems a little strange since these are two very different things: one is a version, and the other is an artifactId and, separately, a versionId. You can see all of the signatures on maven central: https://repo1.maven.org/maven2/org/codehaus/mojo/signature Any ideas? -- To view, visit http://gerrit.cloudera.org:8080/8250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed072138fd42449a477647af4c0cf13b59a5c43 Gerrit-Change-Number: 8250 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 12 Oct 2017 17:19:55 +0000 Gerrit-HasComments: Yes
