Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8277 )
Change subject: [ts_itest-base] split declaration and definition ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/integration-tests/ts_itest-base.cc File src/kudu/integration-tests/ts_itest-base.cc: http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/integration-tests/ts_itest-base.cc@331 PS1, Line 331: SleepFor(MonoDelta::FromMilliseconds(100 * attempts)); > warning: either cast from 'int' to 'int64_t' (aka 'long') is ineffective, o Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.h File src/kudu/tserver/tablet_server-test-base.h: http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.h@106 PS1, Line 106: ScanResponsePB& resp, > warning: non-const reference parameter 'resp', make it const or use a point Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc File src/kudu/tserver/tablet_server-test-base.cc: http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc@142 PS1, Line 142: void TabletServerTestBase::UpdateTestRowRemote(int tid, > warning: parameter 'tid' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc@191 PS1, Line 191: void TabletServerTestBase::InsertTestRowsRemote(int tid, > warning: parameter 'tid' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc@196 PS1, Line 196: string tablet_id, > warning: the parameter 'tablet_id' is copied for each invocation but only u Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc@265 PS1, Line 265: string tablet_id) { > warning: the parameter 'tablet_id' is copied for each invocation but only u Done http://gerrit.cloudera.org:8080/#/c/8277/1/src/kudu/tserver/tablet_server-test-base.cc@393 PS1, Line 393: std::max((size_t)1, std::min((size_t)(expected.size() / 10), > warning: C-style casts are discouraged; use static_cast [google-readability Done -- To view, visit http://gerrit.cloudera.org:8080/8277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31085ad2a6df0df795dad70e9e1c90d34cdd3716 Gerrit-Change-Number: 8277 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 14 Oct 2017 22:43:03 +0000 Gerrit-HasComments: Yes
