Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 )
Change subject: [consensus] adding/removing NON_VOTER members ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/8138/8/src/kudu/consensus/leader_election.cc File src/kudu/consensus/leader_election.cc: http://gerrit.cloudera.org:8080/#/c/8138/8/src/kudu/consensus/leader_election.cc@166 PS8, Line 166: tries > tried Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-itest.cc@204 PS11, Line 204: Status GetTabletCopySourceSessionsCount(const ExternalDaemon& server, > unimplemented Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-itest.cc@208 PS11, Line 208: Status GetTabletCopyTargetSessionsCount(const ExternalDaemon& server, > unimplemented? Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus-nonvoter-itest.cc: PS11: > I think this file should be names raft_consensus_nonvoter-itest.cc Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-nonvoter-itest.cc@250 PS11, Line 250: AssertEventually > use ASSERT_EVENTUALLY() here and below; see the macro definition for an exp Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-nonvoter-itest.cc@257 PS11, Line 257: ASSERT_OK(GetTabletCopyTargetSessionsCount(ed_new_replica, &num_sessions)); > why not put this and the above assertion inside the same ASSERT_EVENTUALLY? Done http://gerrit.cloudera.org:8080/#/c/8138/11/src/kudu/integration-tests/raft_consensus-nonvoter-itest.cc@515 PS11, Line 515: That's > nit: That Done -- To view, visit http://gerrit.cloudera.org:8080/8138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2662d45ad9bb6a4bf325d4202c2ee619ffad02b7 Gerrit-Change-Number: 8138 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 17:59:22 +0000 Gerrit-HasComments: Yes
