Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/7981 )
Change subject: KUDU-2044 Tombstoned tablets show up in /metrics ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7981/7/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/7981/7/src/kudu/util/metrics.h@511 PS7, Line 511: bool published() { > nit: maybe move the comment describing the var here? Because the GSG guideline suggests a method named like this just returns the value of an instance variable, and because published_ needs a doc about its lock anyway, I'm going to keep the comment on the var. -- To view, visit http://gerrit.cloudera.org:8080/7981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b52262203410ded1e514502b59a79be12f8fb3 Gerrit-Change-Number: 7981 Gerrit-PatchSet: 7 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 17 Oct 2017 14:54:46 +0000 Gerrit-HasComments: Yes
