Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8287 )
Change subject: fs: change uuid index from uint16_t to int ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8287/1/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/8287/1/src/kudu/fs/data_dirs.cc@434 PS1, Line 434: int max_data_dirs = block_manager_type_ == "file" ? (1 << 16) - 1 : kuint32max; nit: my fault, can you change this to 'const int kMaxDataDirs' (I must have missed this in separating patches). Also should be INT_MAX now -- To view, visit http://gerrit.cloudera.org:8080/8287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81c8c0588b7bc8ac4a506592f8ac4c77d00fbd8b Gerrit-Change-Number: 8287 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 17 Oct 2017 15:35:13 +0000 Gerrit-HasComments: Yes
