Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8301 )
Change subject: Rename *-path-handlers.* to *_path_handlers.* ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/master/CMakeLists.txt@37 PS1, Line 37: master_path_handlers.cc > Nit: resort Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/master/master.cc@38 PS1, Line 38: #include "kudu/master/master_path_handlers.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/master/master.cc@38 PS1, Line 38: #include "kudu/master/master_path_handlers.h" > Nit: resort. Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/default_path_handlers.h File src/kudu/server/default_path_handlers.h: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/default_path_handlers.h@31 PS1, Line 31: void RegisterMetricsJsonHandler(Webserver* webserver, const MetricRegistry* const metrics); > warning: parameter 'metrics' is const-qualified in the function declaration I don't understand this one. Don't we want the declaration and definition to match, and isn't the const-qualification useful docs when looking at the declaration only? http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/pprof_path_handlers.cc File src/kudu/server/pprof_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/pprof_path_handlers.cc@87 PS1, Line 87: static void PprofHeapHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Spurious- depends on ifdef's http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/pprof_path_handlers.cc@118 PS1, Line 118: static void PprofCpuProfileHandler(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Spurious- depends on ifdef's http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/tracing_path_handlers.cc File src/kudu/server/tracing_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/tracing_path_handlers.cc@44 PS1, Line 44: using std::unique_ptr; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/tracing_path_handlers.cc@129 PS1, Line 129: Status EndRecording(const Webserver::WebRequest& req, > warning: parameter 'req' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/server/tracing_path_handlers.cc@195 PS1, Line 195: void HandleTraceJsonPage(const Webserver::ArgumentMap &args, > warning: parameter 'args' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/tserver/tserver_path_handlers.cc@82 PS1, Line 82: using kudu::MaintenanceManagerStatusPB_MaintenanceOpPB; > warning: using decl 'MaintenanceManagerStatusPB_MaintenanceOpPB' is unused Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/tserver/tserver_path_handlers.cc@83 PS1, Line 83: using kudu::MaintenanceManagerStatusPB_OpInstancePB; > warning: using decl 'MaintenanceManagerStatusPB_OpInstancePB' is unused [mi Done http://gerrit.cloudera.org:8080/#/c/8301/1/src/kudu/tserver/tserver_path_handlers.cc@247 PS1, Line 247: double percent = replicas.size() == 0 ? 0 : (100.0 * entry.second) / replicas.size(); > warning: the 'empty' method should be used to check for emptiness instead o Done -- To view, visit http://gerrit.cloudera.org:8080/8301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7763d69ad484cf45cca6d77badd565843df2dd8 Gerrit-Change-Number: 8301 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 17 Oct 2017 20:05:28 +0000 Gerrit-HasComments: Yes
