Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8307 )
Change subject: [webui] Add templates for tserver webui ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8307/1/src/kudu/tserver/tserver_path_handlers.h File src/kudu/tserver/tserver_path_handlers.h: http://gerrit.cloudera.org:8080/#/c/8307/1/src/kudu/tserver/tserver_path_handlers.h@79 PS1, Line 79: void IteratorStatsToJson(const Schema& projection, > warning: function 'kudu::tserver::TabletServerPathHandlers::TabletsToJson' Done http://gerrit.cloudera.org:8080/#/c/8307/1/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/8307/1/src/kudu/tserver/tserver_path_handlers.cc@221 PS1, Line 221: } > warning: the 'empty' method should be used to check for emptiness instead o Done http://gerrit.cloudera.org:8080/#/c/8307/1/src/kudu/tserver/tserver_path_handlers.cc@477 PS1, Line 477: Webserver::WebResponse* resp) { > warning: parameter 'req' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/8307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99e08be9aa8abddd51ada61683b6f75190a00b5c Gerrit-Change-Number: 8307 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 18 Oct 2017 15:45:17 +0000 Gerrit-HasComments: Yes
