Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 )
Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help ...................................................................... Patch Set 6: > > > Yah, this is basically what I'm thinking. It seems highly > > suspicious to return an error containing user data across the > wire. > > DDL ops are a special case; we don't consider table schemas or > > even partition schemas to be sensitive. Given that, I'm > personally > > fine ignoring the edge-case of error messages in the flag name. > > > > Alright, I can live with this. > > > > Hao, you may want to solicit Todd's opinion too so there's even > > less chance of someone asking for a rework of your patch again > (the > > way I did, sorry about that!). > > No problem at all! Thanks for giving all the suggestions. > > @Dan, I am not quite sure, but look at partition.cc, we are > redacting key value in the return error messages. Will that > eventually be part of the error messages displayed? Though I want to state that I am good with not reverting the definition of --redact and just state it clear in help that 'log' also contains error messages. -- To view, visit http://gerrit.cloudera.org:8080/6755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32fe0c4e65f22d6f9f3d188018b119f07300e26f Gerrit-Change-Number: 6755 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Oct 2017 01:23:27 +0000 Gerrit-HasComments: No
