Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8337 )
Change subject: tool: speed up test runtime a bit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8337/1/src/kudu/tools/tool_test_util.cc File src/kudu/tools/tool_test_util.cc: http://gerrit.cloudera.org:8080/#/c/8337/1/src/kudu/tools/tool_test_util.cc@64 PS1, Line 64: > nit: could you add a comment clarifying why this is necessary? Hmm, moving this here (from RunTool) actually resulted in net more lines of code since most callers don't care. I've moved it back. -- To view, visit http://gerrit.cloudera.org:8080/8337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27c67368b736f864f7cfa3482fdae72acafce851 Gerrit-Change-Number: 8337 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 19 Oct 2017 20:59:42 +0000 Gerrit-HasComments: Yes
