Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8325 )
Change subject: Integrate BlockCreationTransaction into MajorDeltaCompaction ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8325/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8325/1//COMMIT_MSG@15 PS1, Line 15: improvemen > improvement Done http://gerrit.cloudera.org:8080/#/c/8325/1/src/kudu/tablet/delta_compaction.cc File src/kudu/tablet/delta_compaction.cc: http://gerrit.cloudera.org:8080/#/c/8325/1/src/kudu/tablet/delta_compaction.cc@235 PS1, Line 235: RETURN_NOT_OK(base_data_writer_->FinishAndReleaseBlocks(transaction.get())); > Doesn't each of these FinishWithTransaction() calls commit the transaction Right... that defeats the purpose of the change. Thanks for catching it! Updated. -- To view, visit http://gerrit.cloudera.org:8080/8325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I887e20643ac8e4e728f8f91450d2d5059cb33d20 Gerrit-Change-Number: 8325 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 19 Oct 2017 21:22:32 +0000 Gerrit-HasComments: Yes
