Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8338 )
Change subject: WIP log block manager: return early if read-only ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8338/1/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/8338/1/src/kudu/fs/log_block_manager-test.cc@872 PS1, Line 872: // The first write will fail, as the container has been marked read-only. > That seems hard to do: once a container is available, someone can grab it a Currently-running IO for a single tablet will not be stopped, but rather further IO will be prevented. E.g. if a RollingDiskRowSetWriter is writing at the same time as a compaction that's already far enough to be writing to disk, the RDRSW may fail at CommitCreateBlocks() and mark the container read-only just as the compaction is grasping for an available container. The course of action I'm expecting for disk-failure handling is to let the compaction follow through and make sure it sees the read-only container, and fails. -- To view, visit http://gerrit.cloudera.org:8080/8338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06412a36ed62fe1e3a2307a4a2e7a0a7e3d65702 Gerrit-Change-Number: 8338 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 19 Oct 2017 22:51:54 +0000 Gerrit-HasComments: Yes
