Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8361 )
Change subject: KUDU-2170 Masters can start with duplicates specified ...................................................................... KUDU-2170 Masters can start with duplicates specified Users can specify duplicate masters in --master_addresses, where a duplicate includes duplicated names and the same server known by different names. This doesn't cause problems as far as I know, but it looks scary because, for example, the web ui shows extra masters listed in /masters. This is because /masters shows one master per result from ListMasters. This patch deduplicates the output of ListMasters by UUID. It also warns on start if there are exact string duplicates in --master_addresses, at the time the master compares on-disk and configured master addresses, but before the masters are ready to resolve UUIDs. Also, the error message when on-disk and configured masters don't match is confusing. This patch makes it easy to understand. Change-Id: I5047ccf92dde5377da18a1a84e105a951fa5b48c Reviewed-on: http://gerrit.cloudera.org:8080/8341 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> Reviewed-on: http://gerrit.cloudera.org:8080/8361 --- M src/kudu/master/master.cc M src/kudu/master/sys_catalog.cc 2 files changed, 33 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.3.x Gerrit-MessageType: merged Gerrit-Change-Id: I5047ccf92dde5377da18a1a84e105a951fa5b48c Gerrit-Change-Number: 8361 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
