Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8364 )
Change subject: tool: remove dependency on libcurl ...................................................................... tool: remove dependency on libcurl This dependency was introduced in commit 761ce10, when I added support for spawning mini clusters through the CLI tool. We could treat it as a valid new dependency and doc it, but it only exists because of one ExternalDaemon test function. So instead, let's move that function from ExternalDaemon to the group of free functions in cluster_itest_util. I verified that with this patch the CLI no longer depends on kudu_curl_util or on libcurl, and that the build still passes with NO_TESTS=1. Change-Id: Ifcf0b4eeed9f8af38cc471d81eb59a0473f470c3 Reviewed-on: http://gerrit.cloudera.org:8080/8364 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/integration-tests/client-stress-test.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/disk_failure-itest.cc M src/kudu/integration-tests/disk_reservation-itest.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/mini-cluster/CMakeLists.txt M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/util/CMakeLists.txt 19 files changed, 205 insertions(+), 188 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifcf0b4eeed9f8af38cc471d81eb59a0473f470c3 Gerrit-Change-Number: 8364 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
