Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8396 )

Change subject: [tools] limit per-session error buffer space
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc
File src/kudu/tools/tool_action_perf.cc:

http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@88
PS3, Line 88: consider using the
> Nit: simplify to "use the"
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@89
PS3, Line 89: Here is an example
> Nit: "For example" (simpler)
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@185
PS3, Line 185: might
> Nit: may
Done


http://gerrit.cloudera.org:8080/#/c/8396/3/src/kudu/tools/tool_action_perf.cc@219
PS3, Line 219:              "buffer space might impose an additional upper 
limit for the "
> Nit: may
Done



--
To view, visit http://gerrit.cloudera.org:8080/8396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7663c52e57b2d3a1e11b22301b804da784fa74
Gerrit-Change-Number: 8396
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Oct 2017 18:09:32 +0000
Gerrit-HasComments: Yes

Reply via email to