Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 )
Change subject: fs: ensure the existence of important directories on open ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/8399/2/src/kudu/fs/fs_manager.cc@317 PS2, Line 317: Substitute("could not verify required directory $0", d)); > nit: From `man 2 stat` this can fail for a variety of reasons (eg ENOTDIR, Done -- To view, visit http://gerrit.cloudera.org:8080/8399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5238987273886421f8e6f87f850183dc81c8c4ec Gerrit-Change-Number: 8399 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 26 Oct 2017 21:11:49 +0000 Gerrit-HasComments: Yes