Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8407 )
Change subject: [CMakeLists.txt] allow override for openssl on Linux ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8407/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8407/1//COMMIT_MSG@9 PS1, Line 9: If specified, use the override for OPENSSL_ROOT_DIR for Linux builds : even if CENTOS_6_4_OPENSSL_DIR exists. I don't really understand this; wasn't that the intent of the existing code too? http://gerrit.cloudera.org:8080/#/c/8407/1//COMMIT_MSG@12 PS1, Line 12: The prior version didn't work at least with cmake 2.8.12.2. How are you using such an old version of cmake? The beginning of CMakeLists.txt has: # Require cmake that can build LLVM [1]. # # Note: cmake in thirdparty/ will always meet this minimum. # # 1. http://llvm.org/releases/3.9.0/docs/ReleaseNotes.html cmake_minimum_required(VERSION 3.4.3) -- To view, visit http://gerrit.cloudera.org:8080/8407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe69b5d62ef4054e60138a154a85569d92166aff Gerrit-Change-Number: 8407 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 27 Oct 2017 22:09:13 +0000 Gerrit-HasComments: Yes
