Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 )
Change subject: KUDU-2191 (2/n): Hive Metastore client ...................................................................... Patch Set 30: (2 comments) http://gerrit.cloudera.org:8080/#/c/7053/30/src/kudu/hms/hms_client.h File src/kudu/hms/hms_client.h: http://gerrit.cloudera.org:8080/#/c/7053/30/src/kudu/hms/hms_client.h@85 PS30, Line 85: bool cascade = false, : bool delete_data = true) > I'm generally against bool parameters for readability. I liked this C++ tip Done http://gerrit.cloudera.org:8080/#/c/7053/30/src/kudu/hms/hms_client.h@121 PS30, Line 121: int32_t max_events, > I guess there is no way to limit the request by a certain size? eg we might No, right now the interface only allows you to set the maximum number of events. I'd expect we can set this pretty low, at 20 or 100 events and be able to keep pace with the HMS. I'll look into what Sentry HA sets their limit to. -- To view, visit http://gerrit.cloudera.org:8080/7053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I155223da912bc18a759df2f1f6bc25d1132a99ee Gerrit-Change-Number: 7053 Gerrit-PatchSet: 30 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 15:15:43 +0000 Gerrit-HasComments: Yes
