Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8435 )

Change subject: KUDU-1809: Add batch size configuration for ScanToken API
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8435/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/8435/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@657
PS1, Line 657:     KuduScanToken.KuduScanTokenBuilder tokenBuilder =
> On second thought that may not necessarily work.  Maybe check to see how ba
Looked a bit and found that another reliable way to test is to set the batch 
size bytes to be 0, so that the first call to the tablet server won't return 
any data. Will update the test based on this.



--
To view, visit http://gerrit.cloudera.org:8080/8435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie147ba4aa8e457c7063f7bb5b51b4e7e0bd1fe73
Gerrit-Change-Number: 8435
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Wed, 01 Nov 2017 19:32:31 +0000
Gerrit-HasComments: Yes

Reply via email to