Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 )
Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc File src/kudu/integration-tests/master_replication-itest.cc: http://gerrit.cloudera.org:8080/#/c/8393/2/src/kudu/integration-tests/master_replication-itest.cc@333 PS2, Line 333: // - 1, in the case that one master had become leader by the time we connected. : EXPECT_LE(successes, 1); > Given this test doesn't push any kind of stress workload, I think it would SGTM. I asked because I saw the pre-commit build didn't fail for the TSAN configuration, while other builds failed due the the typo below (however, I haven't looked deeper). -- To view, visit http://gerrit.cloudera.org:8080/8393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52f903e1aa5ae6948ca1ba6d4d856c3c9dc73d56 Gerrit-Change-Number: 8393 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 02 Nov 2017 02:58:41 +0000 Gerrit-HasComments: Yes