Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/22/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/7439/22/src/kudu/tablet/tablet.h@562 PS22, Line 562: CheckNotStopped Between Stopped() and CheckNotStopped() I think we are introducing a new lifecycle state (i.e. state_) while allowing for something to be both kOpen and Stopped(). Based on that I think we should bite the bullet and find a way to transition the state outside of taking the component_lock_, perhaps by introducing a state_lock_ spinlock specifically to access state_. I'd be interested in Todd's thoughts on this, too. -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 22 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2017 01:44:14 +0000 Gerrit-HasComments: Yes
