Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 )
Change subject: WIP: test and fixes for tls socket EINTR issues ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8462/1/src/kudu/security/tls_socket-test.cc File src/kudu/security/tls_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/8462/1/src/kudu/security/tls_socket-test.cc@181 PS1, Line 181: } > Mind calling client_sock->Close()? Oh, ignore that one. I mean it would be easier to follow if the client explicitly closed the connection and set 'stop == true' and not calling the SleepFor() in the last iteration. -- To view, visit http://gerrit.cloudera.org:8080/8462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibec9049186f79f1c43295e4735538ed7ba4e516e Gerrit-Change-Number: 8462 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 03 Nov 2017 22:20:49 +0000 Gerrit-HasComments: Yes
