Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 )
Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: http://gerrit.cloudera.org:8080/#/c/8452/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@101 PS1, Line 101: public static byte[] serialize(ScanTokenPB message) throws IOException { Can this be package private? We really try not to expose protobuf classes if possible n the public API. -- To view, visit http://gerrit.cloudera.org:8080/8452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If427be16d1fff60271b362134686793ffdbc19f9 Gerrit-Change-Number: 8452 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 06 Nov 2017 17:25:34 +0000 Gerrit-HasComments: Yes
