Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8481 )
Change subject: cmake: use MAKE_C_IDENTIFIER to generate valid target names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71f145c08d7fbb5627442b6527b3feebc05055bd Gerrit-Change-Number: 8481 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 06 Nov 2017 19:38:22 +0000 Gerrit-HasComments: No