Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8488 )
Change subject: [hybrid_clock-test] adapt the test for OS X ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc File src/kudu/clock/hybrid_clock-test.cc: http://gerrit.cloudera.org:8080/#/c/8488/2/src/kudu/clock/hybrid_clock-test.cc@45 PS2, Line 45: DECLARE_bool(inject_unsync_time_errors); I think it'd be cleaner to rename the existing 'inject_adjtimex_errors' to 'inject_unsync_time_errors', and then use it from both TimeService implementations. The only issue is where to define it - the obvious place is time_service.cc, but that doesn't exist yet. It could, though. -- To view, visit http://gerrit.cloudera.org:8080/8488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a4b139eb6b0b5c79bce48eedb24bc7c445970c Gerrit-Change-Number: 8488 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 07 Nov 2017 21:25:15 +0000 Gerrit-HasComments: Yes
