Mike Percy has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/8495 )
Change subject: Suppress -Wcomment compiler warnings
......................................................................
Suppress -Wcomment compiler warnings
We have a bunch of annoying warnings in otherwise-normal g++ builds.
Let's get rid of these unnecessary warnings. Examples:
[765/1328] Building CXX object
src/kudu/util/CMakeFiles/interval_tree-test.dir/interval_tree-test.cc.o
In file included from ../../src/kudu/util/interval_tree-test.cc:37:0:
../../src/kudu/util/interval_tree-inl.h:269:3: warning: multi-line comment
[-Wcomment]
// [------] \
^
../../src/kudu/util/interval_tree-inl.h:308:3: warning: multi-line comment
[-Wcomment]
// [--------] \
^
[943/1328] Building CXX object
src/kudu/server/CMakeFiles/server_process.dir/webserver.cc.o
../../src/kudu/server/webserver.cc:360:5: warning: multi-line comment
[-Wcomment]
// https://github.com/cloudera/squeasel/blob/\
^
[995/1328] Building CXX object
src/kudu/tablet/CMakeFiles/tablet.dir/rowset_tree.cc.o
In file included from ../../src/kudu/tablet/rowset_tree.cc:33:0:
../../src/kudu/util/interval_tree-inl.h:269:3: warning: multi-line comment
[-Wcomment]
// [------] \
^
../../src/kudu/util/interval_tree-inl.h:308:3: warning: multi-line comment
[-Wcomment]
// [--------] \
^
[1218/1328] Building CXX object
src/kudu/tools/CMakeFiles/kudu.dir/tool_action_perf.cc.o
../../src/kudu/tools/tool_action_perf.cc:33:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen \
^
../../src/kudu/tools/tool_action_perf.cc:49:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen \
^
../../src/kudu/tools/tool_action_perf.cc:65:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen \
^
../../src/kudu/tools/tool_action_perf.cc:82:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen \
^
../../src/kudu/tools/tool_action_perf.cc:94:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen 127.0.0.1 --table_name=t3 --num_threads=2 \
^
../../src/kudu/tools/tool_action_perf.cc:97:1: warning: multi-line comment
[-Wcomment]
// kudu perf loadgen 127.0.0.1 --table_name=t3 --num_threads=2 \
^
../../src/kudu/tools/tool_action_perf.cc:100:1: warning: multi-line comment
[-Wcomment]
// perf perf loadgen 127.0.0.1 --table_name=t3 --num_threads=2 \
^
Change-Id: Ic320fa11a6f67ed107b1fff2b1f2da7f7bd39cd0
Reviewed-on: http://gerrit.cloudera.org:8080/8495
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic320fa11a6f67ed107b1fff2b1f2da7f7bd39cd0
Gerrit-Change-Number: 8495
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
