Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8533 )
Change subject: Add initial internal INT128/__int128 support ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8533/2/src/kudu/util/int128.cc File src/kudu/util/int128.cc: http://gerrit.cloudera.org:8080/#/c/8533/2/src/kudu/util/int128.cc@30 PS2, Line 30: v = -v; This is wrong for the minimum value. FastInt128ToBufferLeft does it right. http://gerrit.cloudera.org:8080/#/c/8533/2/src/kudu/util/int128.cc@37 PS2, Line 37: std::ostream& operator<<(std::ostream& os, const unsigned __int128& val) { > The main reason is that this implementation is very heavily borrowed from i I think it'd be better to call into that implementation here in order to define operator<<, so we don't have two implementations of the same algorithm in the codebase. The google impl is also a bit simpler (no loop). -- To view, visit http://gerrit.cloudera.org:8080/8533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36458a54dfdd28be03f80d83688c0d658944e8e1 Gerrit-Change-Number: 8533 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 13 Nov 2017 22:36:29 +0000 Gerrit-HasComments: Yes
