Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 )
Change subject: [RaftPeerPB] introduce replica health status ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8561/1/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: http://gerrit.cloudera.org:8080/#/c/8561/1/src/kudu/consensus/metadata.proto@75 PS1, Line 75: This is run-time : // only field, it should not be persisted or read from the persistent storage. > is this true even on the master? or would we expect the master to persist i Ah, I see -- it seems I missed the PROMOTE and REPLACE attributes. I'll add them for the complete picture, sure. By my understanding, master does not need to persist the health status. Overall, it's not necessary to know the previous state of the health status of a replica, it's enough to see what current status is. Do you have some use case in mind when master would get super-confused with 'extra' replicas? If the leader master changes, master is about to receive non-incremental report on all tablets in the system. -- To view, visit http://gerrit.cloudera.org:8080/8561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82f838fd3612ab9bc3f91cac7a840cb9f36ff4c Gerrit-Change-Number: 8561 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 Nov 2017 01:45:57 +0000 Gerrit-HasComments: Yes
