Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8570 )
Change subject: WIP: tls_socket: properly handle temporary socket errors in Writev ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8570/1/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/8570/1/src/kudu/security/tls_socket.cc@99 PS1, Line 99: if (total_written > 0 && Socket::IsTemporarySocketError(write_status.posix_code())) { : return Status::OK(); : } Does this really help? I'm not sure that would help in some cases. My concern is if it was a partial write indeed, the upper-level caller (i.e. OutboundTransfer::SendBuffer()) will adjust the cur_offset_in_slice_, so the next time it will call TlsSocket::Writev() with different buffer and offset, that would result calling SSL_write() with different parameters. However, SSL_write() expects the follow-up call after SSL_ERROR_WANT_WRITE to be exactly with the same set parameters that was used when SSL_write() returned SSL_ERROR_WANT_WRITE. -- To view, visit http://gerrit.cloudera.org:8080/8570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If797f220f42bfb2e6f452b66f15e7a758e883472 Gerrit-Change-Number: 8570 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Nov 2017 19:12:40 +0000 Gerrit-HasComments: Yes
