Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8561 )
Change subject: [RaftPeerPB] introduce attributes and health status ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8561/3/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: http://gerrit.cloudera.org:8080/#/c/8561/3/src/kudu/consensus/metadata.proto@42 PS3, Line 42: HealthStatus nit: I think this should be named HealthStatusPB to indicate that it's defined in a protobuf file. Other examples of enums that left this out are a mistake http://gerrit.cloudera.org:8080/#/c/8561/3/src/kudu/consensus/metadata.proto@48 PS3, Line 48: nit: trailing space http://gerrit.cloudera.org:8080/#/c/8561/3/src/kudu/consensus/metadata.proto@97 PS3, Line 97: insert: a -- To view, visit http://gerrit.cloudera.org:8080/8561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82f838fd3612ab9bc3f91cac7a840cb9f36ff4c Gerrit-Change-Number: 8561 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 Nov 2017 23:02:21 +0000 Gerrit-HasComments: Yes
