Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8595 )
Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8595/2/src/kudu/security/test/test_certs.cc File src/kudu/security/test/test_certs.cc: http://gerrit.cloudera.org:8080/#/c/8595/2/src/kudu/security/test/test_certs.cc@506 PS2, Line 506: CreateTestSSLCertSignedByChain > I basically added the intermediate cert (from 'kCaChainCert' below) to the Yes, I understand that these function does not differ if the only one certificate is provided. I asked because it seemed to me that previously we used self-signed cert here. If an intermediary CA is already present, then it would be all right then. However, I don't understand the following: how could it work with other than self-signed cert in the previous version if the intermediate cert was not presented by the server? -- To view, visit http://gerrit.cloudera.org:8080/8595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e3f913259ec4c855ff211726fa6ecea94d328e7 Gerrit-Change-Number: 8595 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2017 18:49:45 +0000 Gerrit-HasComments: Yes
