Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 )
Change subject: tablet: make various update paths atomic ...................................................................... Patch Set 11: > Patch Set 11: > > Any idea what the coverage of these code paths look like? eg with your > injected failures test, do these paths actually get hit? Maybe it's worth > some WARNING when these more complex cases get hit, so if we do have some > subtle bug here, we will have smoking guns in the log that make us associate > the issue with this complex rollback stuff. Yeah, most if not all of the paths here get hit at some point with enough dist test runs. I'll add a WARNING for the rollback. -- To view, visit http://gerrit.cloudera.org:8080/8441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0241cd4206ce77ef1fb334458b091bc2092f4141 Gerrit-Change-Number: 8441 Gerrit-PatchSet: 11 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 07:29:24 +0000 Gerrit-HasComments: No
