Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8618 )
Change subject: Add a test for data consistency after stopping tablets ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8618/1/src/kudu/integration-tests/cluster_verifier.cc File src/kudu/integration-tests/cluster_verifier.cc: http://gerrit.cloudera.org:8080/#/c/8618/1/src/kudu/integration-tests/cluster_verifier.cc@107 PS1, Line 107: cluster_->master_rpc_addrs() Seems like this is empty for single-master clusters / by default. I think this should do what you want: for (int i = 0; i < cluster_->num_masters(); i++) { hp_strs.emplace_back(cluster_->master(i)->bound_rpc_hostport()); } http://gerrit.cloudera.org:8080/#/c/8618/1/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/8618/1/src/kudu/tools/ksck_remote.cc@323 PS1, Line 323: CHECK(!master_addresses.empty()); Seems this is breaking a bunch of test cases. Is it necessary? -- To view, visit http://gerrit.cloudera.org:8080/8618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b3b9e90fd1fbfb555a22074fd4a777a2b2e56e2 Gerrit-Change-Number: 8618 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:04:41 +0000 Gerrit-HasComments: Yes
