Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8551 )
Change subject: [spark] Remove syncCache in KuduConnection ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8551/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/8551/4/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@60 PS4, Line 60: if (authnCredentials != null) { : c.importAuthenticationCredentials(authnCredentials) : } : c In order to avoid importing authentication credentials twice to the client, you could simplify this to @transient lazy val syncClient: KuduClient = asyncClient.syncClient() -- To view, visit http://gerrit.cloudera.org:8080/8551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica8745d8503a35e17a632d0a0cde5738915f00fb Gerrit-Change-Number: 8551 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 20:10:11 +0000 Gerrit-HasComments: Yes
