Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8557 )
Change subject: ntp: dump NTP diagnostics when NTP is unsynchronized or error is too high ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/8557/4/src/kudu/clock/system_ntp.h File src/kudu/clock/system_ntp.h: http://gerrit.cloudera.org:8080/#/c/8557/4/src/kudu/clock/system_ntp.h@50 PS4, Line 50: log > can't do default parameters since it's a virtual method (tidy complained) ah, sure http://gerrit.cloudera.org:8080/#/c/8557/4/src/kudu/clock/system_ntp.cc File src/kudu/clock/system_ntp.cc: http://gerrit.cloudera.org:8080/#/c/8557/4/src/kudu/clock/system_ntp.cc@90 PS4, Line 90: ERROR > I wanted to log the whole thing at ERROR level since this is only used righ sgtm -- To view, visit http://gerrit.cloudera.org:8080/8557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeb2206a0475b8c8e183a74aee21315e6e43dc33 Gerrit-Change-Number: 8557 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 00:22:25 +0000 Gerrit-HasComments: Yes
